ext/curl: post multiple similarly-named files with curl - #22740
Open
Sjord wants to merge 1 commit into
Open
Conversation
Sjord
force-pushed
the
curl-post-multi-file
branch
from
July 15, 2026 12:24
022fc17 to
c8f8de7
Compare
Make it possible to post multiple files with the same name using cURL. It was already possible to post files, and it was possible to post multiple strings with the same name. This moves things around to combine these two features. Closes php#15859
Sjord
force-pushed
the
curl-post-multi-file
branch
from
July 15, 2026 12:44
c8f8de7 to
aece997
Compare
Sjord
marked this pull request as ready for review
July 15, 2026 12:58
Contributor
Author
Sjord
changed the title
Contributor
Author
|
@cmb69 could you perhaps review this please? |
Girgias
requested changes
Aug 7, 2026
Girgias
left a comment
Girgias
left a comment
Member
There was a problem hiding this comment.
Mixing part of the refactoring with the behavioural changes makes it hard to follow along.
Could you maybe first split build_mime_structure_from_hash into multiple functions dealing with the different types in a different PR, and then rebase this PR when that one landed?
Contributor
Author
|
I agree that the changes view of this PR is a mess. I moved the inner loop from build_mime_structure_from_hash to its own function. There are hardly any other changes. Splitting this up into multilple pull requests is not going to make things clearer, I'm afraid. Could you take a look at this PR with white-space changes ignored? I think that makes it easier to see what's going on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#15859